Merged
Conversation
zcbenz
approved these changes
Mar 31, 2026
Collaborator
zcbenz
left a comment
zcbenz
left a comment
There was a problem hiding this comment.
Very nice implementation 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simplified and correct version of #3319. The main point is that it moves the batch axis first and takes advantage of the BroadcastAxes primitive's negative axes handling (which was made for this tbh) to avoid all axis math. Unfortunately we may need to expand to move the vectorized axis first if the dims are smaller.
In addition to the above it makes sure that the BroadcastAxes primitive is used even when it is a noop to have a consistent graph that works all the time. Basically dealing with the broadcast version of #3202.